In this paper advance in cucumber breeding in China for forty years was summarized from yield,disease resistance,quality,method and technology of breeding;the problems we are facing and the trend of cucumber breeding in China in the 21st century were discussed.